feat: add chat.getUser() for cross-platform user lookups#391
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@heyitsaamir any chance we can add Teams support for this? |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
It should be possible! const member = await app.api.conversations
.members(activity.conversation.id)
.getById(activity.from.id);Lmk if that doesn't work! |
|
So the above will get you the member, but it requires the conversation id. Members in Teams aren't global members, but more based on membership of a conversation. If you want global members, you can do that via graph, but it'll require some graph permissions i believe ( const graphUser = await app.graph.call(endpoints.users.get({ 'user-id': activity.from.aadObjectId! })); |
Ah thank you for this! Do you by any chance have time to push it to the PR? Mainly ask as you'd know exactly which methods to use and what to troubleshoot accordingly |
Give me a couple of days :). I can include it after this PR goes in? |
That'd be perfect, thank you so much! |
Add UserInfo type and optional getUser() method to the Adapter interface. Implement on Slack (extends existing lookupUser with email/avatar), Discord, Google Chat, GitHub, Linear, and Telegram adapters. Add "Who Am I" button to the example app demonstrating the feature. Update docs with getUser API reference and usage examples.
- slack: return null from lookupUser on failure instead of fallback object, removing the isBot === undefined sentinel in getUser - slack: use image_192 instead of image_72 for better avatar quality - gchat: cache avatarUrl from webhook sender payload - gchat: return avatarUrl in getUser response - gchat: fix tests to use current cache format with isBot field - docs: document null return, fix example to use message.author
* feat(adapter-teams): add getUser() via Microsoft Graph API
- Cache aadObjectId from activity.from during webhook handling
- Implement getUser() using Graph GET /users/{user-id} endpoint
- Requires User.Read.All application permission
- Returns null gracefully when user hasn't interacted or Graph call fails
* docs: add getUser() section to Teams adapter README
…-platform constraints
- Slack `_lookup_user`: detect empty `{user: {}}` success payload and
return the `_lookup_failed` sentinel instead of caching a
`UserInfo(Uxxx, Uxxx, Uxxx)` shape that `get_user` would convert into
a non-null fallback. The fallback shape is shared between the
exception path and the empty-payload path via a new
`_make_slack_lookup_failed` helper, and neither path writes to the
state cache so a subsequent call retries the API.
- Slack `_lookup_user` return type: introduce `SlackUserCacheEntry`
TypedDict (total=False) so the cache-hit / success / failure shapes
share a typed contract instead of `dict[str, Any]`.
- Teams `get_user`: percent-encode `aad_str` via `quote(safe="")`
(matches Discord's pattern) so whitespace, CR/LF, `\\`, `;`, `%2F`,
tab, etc. cannot escape the `/v1.0/users/` path segment. The
structural-splitter reject list (`/`, `?`, `#`) stays as a fast-path
reject before the encoding pass.
- Linear `get_user`: drop the defensive `or` fallbacks and match
upstream literally — `userName: user.displayName, fullName:
user.name` (vercel/chat#391).
Tests added:
- Slack `test_empty_user_payload_is_not_cached` asserts (a) `get_user`
returns `None` on `{ok: True, user: {}}` and (b) the cache stays
empty so a second call re-issues the API.
- Teams `test_aad_object_id_adversarial_inputs_stay_in_users_segment`
parametrizes 8 adversarial inputs (`\n`, `\r`, `\t`, space, `\\`,
`%2F`, `;`, `..`) and asserts each is either rejected or
percent-encoded such that the resulting URL stays under
`https://graph.microsoft.com/v1.0/users/`.
https://claude.ai/code/session_01FyMxQn2BEAzmwKS1GZczKj
3 participants
UserInfotype and optionalgetUser()method to theAdapterinterfacenullwhen user not found, throwsChatError("NOT_SUPPORTED")for adapters without supportUserInfotype table, and error handling examples